509 compiler warnings later

Spent most of today fixing up things that cause gcc to whine about RPM source. Comparing rpm-4.4.2.1-rc3 vs current rpm.org head:

[pmatilai@localhost rpm]$ grep warning build.warnings.4421|wc -l
871
[pmatilai@localhost rpm]$ grep warning build.warnings|wc -l
362

Of the remaining 362 warnings, 252 come from Berkeley DB, so just over 100 more warnings to deal with still in actual rpm code. Of those, roughly a third come from debugedit.c alone… In any case, the build looks a whole lot less scary than it used to. Another big cleanup-round or two (these numbers are with -fno-strict-aliasing, removing that reopens another can of worms) and it might start to be possible to actually spot warnings from new code as it gets written.

Comments are closed.